[Mesa-dev] [PATCH] r300g: Fix the ATI1N swizzle.

Ilia Mirkin imirkin at alum.mit.edu
Mon Mar 9 09:28:24 PDT 2015


On Mon, Mar 9, 2015 at 12:26 PM, Stefan Dösinger <stefandoesinger at gmx.at> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Am 2015-03-09 um 17:19 schrieb Ilia Mirkin:
>> It also has the additional problem that it doesn't do the swizzle
>> workaround which apparently is necessary even for single-component
>> textures.
> Do you mean the change I made in my patch? That part works just fine
> for the signed one component value. It seemed that a workaround for
> S3TC values was incorrectly applied to RGTC values, but I could not
> find information about that in the GPU docs. Maybe the if condition I
> changed should be modified to whitelist formats rather than blacklist.

No, I meant the SNORM formats. It does the snorm-from-unorm fixup, but
it doesn't do the swizzle fixup (which seems like it'd be required
given your findings about unorm).

  -ilia


More information about the mesa-dev mailing list