[Mesa-dev] [PATCH 02/15] gallium: add new fields to pipe_driver_query_info

[Samuel Pitoiset]

On 03/09/2015 10:36 PM, Marek Olšák wrote:
> On Mon, Mar 9, 2015 at 10:09 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> According to the spec of GL_AMD_performance_monitor, valid type values
>> returned are UNSIGNED_INT, UNSIGNED_INT64_AMD, PERCENTAGE_AMD, FLOAT.
>> This also introduces the new field group_id in order to categorize
>> queries into groups.
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   src/gallium/include/pipe/p_defines.h | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
>> index 4409789..cb42cef 100644
>> --- a/src/gallium/include/pipe/p_defines.h
>> +++ b/src/gallium/include/pipe/p_defines.h
>> @@ -751,12 +751,22 @@ union pipe_color_union
>>      unsigned int ui[4];
>>   };
>>
>> +enum pipe_driver_query_type
>> +{
>> +   PIPE_DRIVER_QUERY_TYPE_UINT64     = 0,
>> +   PIPE_DRIVER_QUERY_TYPE_UINT       = 1,
>> +   PIPE_DRIVER_QUERY_TYPE_FLOAT      = 2,
>> +   PIPE_DRIVER_QUERY_TYPE_PERCENTAGE = 3,
> What's the type of percentage? UINT64? FLOAT?

Numeric types are described in the following patch,
but UINT64 is uint64_t, UINT is uint32_t, FLOAT and PERCENTAGE are float.

>
>> +};
>> +
>>   struct pipe_driver_query_info
>>   {
>>      const char *name;
>>      unsigned query_type; /* PIPE_QUERY_DRIVER_SPECIFIC + i */
>>      uint64_t max_value; /* max value that can be returned */
>>      boolean uses_byte_units; /* whether the result is in bytes */
>> +   enum pipe_driver_query_type type;
> Could you please remove uses_byte_units and add PIPE_DRIVER_QUERY_TYPE_BYTES,
> which should return uint64_t?

Yeah, good idea! I'll make this change and submit a v2 in few days.

>
> Marek