[Mesa-dev] [PATCH] i965: Issue perf_debug messages for unsynchronized maps on !LLC systems.

Ben Widawsky ben at bwidawsk.net
Mon Mar 9 21:23:20 PDT 2015


On Tue, Feb 24, 2015 at 09:34:30PM -0800, Kenneth Graunke wrote:
> We haven't implemented proper unsynchronized map support on !LLC systems
> (pre-SNB, Atom).  MapBufferRange with GL_MAP_UNSYNCHRONIZE_BIT will
> actually do a synchronized map, probably killing performance.
> 
> Also warn on BufferSubData, when we should be doing an unsynchronized
> upload, but instead have to do a synchronous map.
> 
> v2: Only complain if the buffer is actually busy - we use unsynchronized
>     maps internally for vertex upload and such, but expect those to not
>     be busy.
> 
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>

Sorry I let this slip. I actually thought it was merged, and screwed up the
patchwork state.

This is both:
Tested-by: Ben Widawsky <ben at bwidawsk.net> &&
Reviewed-by: Ben Widawsky <ben at bwidawsk.net>

My only nit is that I do already have the fix for this. Not sure if we want to
pursue that instead. I'll defer to you.

-- 
Ben Widawsky, Intel Open Source Technology Center


More information about the mesa-dev mailing list