[Mesa-dev] [PATCH 2/2] nir: Optimize a + neg(a)

Ian Romanick idr at freedesktop.org
Tue Mar 10 16:20:08 PDT 2015


On 02/28/2015 12:19 PM, Matt Turner wrote:
> On Sat, Feb 28, 2015 at 11:47 AM, Thomas Helland
> <thomashelland90 at gmail.com> wrote:
>> On Feb 28, 2015 8:39 PM, "Jason Ekstrand" <jason at jlekstrand.net> wrote:
>>>
>>> Both patches are
>>>
>>> Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>
>>
>> Could you commit them?
>> I don't have commit access.
> 
> I'd like to wait a few days to see if there are any comments about the
> floating-point optimizations. If not, I'll commit them. (The integer
> parts are surely fine)

Hmm... does the GLSL spec say anything about integer overflow?  For
large values, (a*b)+(a*c) can produce dramatically different results
than a*(b+c).

> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev



More information about the mesa-dev mailing list