[Mesa-dev] [PATCH 1/2] util: Fix foreach_list_typed_safe when exec_node is not at offset 0.

Kenneth Graunke kenneth at whitecape.org
Tue Mar 10 20:49:26 PDT 2015


On Tuesday, March 10, 2015 05:48:20 PM Jason Ekstrand wrote:
> On Tue, Mar 10, 2015 at 5:45 PM, Matt Turner <mattst88 at gmail.com> wrote:
> 
> > On Tue, Mar 10, 2015 at 1:09 PM, Jason Ekstrand <jason at jlekstrand.net>
> > wrote:
> > > How about we do things slightly differently and check
> > "(__node)->field.next
> > > != NULL" just like we do on regular versions.  Since the check happens
> > > between the increment step and running the user's code, __node is valid
> > for
> > > every invocation of the checking condition.  Would that make you feel
> > better
> > > about it?
> >
> > Yeah, that seems a lot clearer.
> >
> 
> Ken,
> Are you ok with that?  If so, do you want to make the change or shall I?
> --Jason

I think that should work, and is probably clearer.  I'll let you do it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150310/78f7c7dd/attachment-0001.sig>


More information about the mesa-dev mailing list