[Mesa-dev] [PATCH 5/5] i965/fs: Apply gl_FrontFacing ? -1 : 1 optimization only for floats

Matt Turner mattst88 at gmail.com
Wed Mar 11 16:10:27 PDT 2015


On Wed, Mar 11, 2015 at 1:44 PM, Ian Romanick <idr at freedesktop.org> wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> At the very least, unreal4/sun-temple/102.shader_test uses this pattern
> for a signed integer result.  However, that shader did not hit the
> optimization in the first place because it uses !gl_FronFacing.  I
> changed the shader to use remove the logical-not and reverse the other
> operands.  I verified that incorrect code is generated before this
> change and correct code is generated after.

At one point I did have a patch that handled !gl_FrontFacing ? ... but
I think it got lost.

4-5 are

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list