[Mesa-dev] [PATCH 1/5] i965/vs: Add missing resolve_bool_comparison calls on GEN4 and GEN5

Abdiel Janulgue abdiel.janulgue at linux.intel.com
Thu Mar 12 02:17:03 PDT 2015


On 03/11/2015 10:44 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> The ir_unop_any problem was discovered by some later optimization passes
> that generate ir_triop_csel.  I was also able to reproduce it by
> modifying the gl-2.0-vertexattribpointer vertex shader to generate its
> result using
>
>     color = mix(vec4(0, 1, 0, 0),
>                 vec4(1, 0, 0, 0),
>                 bvec4(any(greaterThan(diff, vec4(tolerance)))));
>
> instead of an if-statement.  This also required using #version 130 and
> MESA_GLSL_VERSION_OVERRIDE=130.
>
> I have not nominated this for stable releases because I don't think
> there's any way to trigger the problem without GLSL 1.30 or
> optimizations that don't exist in stable.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>

Patch 1 is

Reviewed-by: Abdiel Janulgue <abdiel.janulgue at linux.intel.com>


More information about the mesa-dev mailing list