[Mesa-dev] [PATCH 1/2] glsl: Expose built-in packing functions under GLSL 4.2.

Marek Olšák maraeo at gmail.com
Thu Mar 12 02:55:58 PDT 2015


Thanks. I noticed this too, but was too busy to fix it.

For the series:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Thu, Mar 12, 2015 at 2:45 AM, Matt Turner <mattst88 at gmail.com> wrote:
> ARB_shading_language_packing is part of GLSL 4.2, not 4.0 as I
> mistakenly believed. The following functions are available only with
> ARB_shading_language_packing, GLSL 4.2 (not GLSL 4.0), or ES 3.0:
>
>    - packSnorm2x16
>    - unpackSnorm2x16
>    - packHalf2x16
>    - unpackHalf2x16
> ---
>  src/glsl/builtin_functions.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp
> index 84bbdc2..c607572 100644
> --- a/src/glsl/builtin_functions.cpp
> +++ b/src/glsl/builtin_functions.cpp
> @@ -201,7 +201,7 @@ static bool
>  shader_packing_or_es3(const _mesa_glsl_parse_state *state)
>  {
>     return state->ARB_shading_language_packing_enable ||
> -          state->is_version(400, 300);
> +          state->is_version(420, 300);
>  }
>
>  static bool
> --
> 2.0.5
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list