[Mesa-dev] [PATCH 2/2] nir: Optimize a + neg(a)

[Erik Faye-Lund]

On Sat, Feb 28, 2015 at 9:19 PM, Matt Turner <mattst88 at gmail.com> wrote:
> On Sat, Feb 28, 2015 at 11:47 AM, Thomas Helland
> <thomashelland90 at gmail.com> wrote:
>> On Feb 28, 2015 8:39 PM, "Jason Ekstrand" <jason at jlekstrand.net> wrote:
>>>
>>> Both patches are
>>>
>>> Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>
>>
>> Could you commit them?
>> I don't have commit access.
>
> I'd like to wait a few days to see if there are any comments about the
> floating-point optimizations. If not, I'll commit them. (The integer
> parts are surely fine)

"a + - a" should give NaN if a is NaN or INF, not zero. However, the
GLSL spec says "NaNs are not required to be generated" and "Operations
and built-in functions that operate on a NaN are not required to
return a NaN as the result".

So I think the patch is good.