[Mesa-dev] [PATCH 1/3] mesa: Replace _mesa_round_to_even() with _mesa_roundeven().

Carl Worth cworth at cworth.org
Thu Mar 12 15:26:06 PDT 2015


On Thu, Mar 12 2015, Carl Worth wrote:
> But beyond that, I'm actually confused---how can the default rounding
> mode (rounding toward nearest number, right?) give us an adequate
> implementation for roundeven()?

Of course, I had asked for (and received) a patch with a test. And the
test verifies that rint() with the default rounding is working.

(I also verified that with an explicit call to fesetround(FE_TONEAREST)
in the test, the test still passes, and similarly that a call to
fesetround with any of the other values makes it fail.)

So I'll clarify my confusion separately, but it doesn't necessarily
point to any problem in the code.

-Carl

PS. And with that testing, here's my official:

Reviewed-by: Carl Worth <cworth at cworth.org>

for the testing patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150312/955589f0/attachment.sig>


More information about the mesa-dev mailing list