[Mesa-dev] [PATCH 3/4 v3] mesa: Separate PBO validation checks from buffer mapping, to allow reuse

Eduardo Lima Mitev elima at igalia.com
Fri Mar 13 09:00:49 PDT 2015


Hi,

I just merged the 4 patches after fixing your last comments.

Thanks a lot for your reviews and patience.

cheers,
Eduardo

On 03/12/2015 06:22 PM, Laura Ekstrand wrote:
> 
> On Thu, Mar 12, 2015 at 12:14 AM, Eduardo Lima Mitev <elima at igalia.com
> <mailto:elima at igalia.com>> wrote:
> 
>                                        format, type, clientMemSize, ptr)) {
>            if (_mesa_is_bufferobj(unpack->BufferObj)) {
>               _mesa_error(ctx, GL_INVALID_OPERATION,
> 

> Add the "PBO" back to this comment.

> 
>     -                     "%s(out of bounds PBO access)", where);
>     +                     "%s(out of bounds access)",
>     +                     where);
>            } else {
>               _mesa_error(ctx, GL_INVALID_OPERATION,
>                           "%s(out of bounds access: bufSize (%d) is too
> 

> With that fixed,
> 
> Reviewed-by: Laura Ekstrand <laura at jlekstrand.net
> <mailto:laura at jlekstrand.net>>



More information about the mesa-dev mailing list