[Mesa-dev] [PATCH 1/1] Fix runtime error with uClibc

[Emil Velikov]

Hi Bernd,
On 15/03/15 11:27, Bernd Kuhls wrote:
> Patch inspired by
> https://www.winehq.org/pipermail/wine-bugs/2011-September/288987.html
> http://git.alpinelinux.org/cgit/aports/tree/main/wine/uclibc-fmaxf-fminf.patch?id=c9b491b6099eec02a835ffd05539b5c783c6c43a
> 
> Starting an app using mesa3d 10.5.x, Kodi for example, fails:
> 
> /usr/lib/kodi/kodi.bin: symbol 'fminf': can't resolve symbol in lib '/usr/lib/dri/i965_dri.so'.
> libGL error: unable to load driver: i965_dri.so
> libGL error: driver pointer missing
> libGL error: failed to load driver: i965
> libGL error: unable to load driver: swrast_dri.so
> libGL error: failed to load driver: swrast
> 
> Here is some background information about the fminf/fmaxf situation in uClibc:
> http://thread.gmane.org/gmane.comp.lib.uclibc.general/24189
> 
> Please backport this patch to the 10.5 branch.
> 
I second Matt's concern here. It seems that the uclibc devs are pulling
a silly excuse here. That aside I believe everyone will be happy with a
solution like the following:

 - Add a check in configure that the function is declared, but the
binary fails to link. AC_CHECK_FUNC or AC_COMPILE_IFELSE/AC_LINK_IFELSE
+ AC_LANG_PROGRAM, are the things you're interested.

 - If that's the case set a define, and use it to guard a custom
solution in include/c99_math.h. Please do consider that one or both
floats can be NaN.


To nominate the patch for 10.5 just add the following line in the commit
message.

Cc: "10.5" <mesa-stable at lists.freedesktop.org>


Thanks
Emil