[Mesa-dev] [PATCH 1/2] i965/fs: Force promotion of src0 immediates.

Kenneth Graunke kenneth at whitecape.org
Mon Mar 16 14:44:15 PDT 2015


On Monday, March 16, 2015 07:54:45 AM Tapani Pälli wrote:
> My first attempt to fix the bug 89569 was to add check in combine 
> constants but for some reason I did not get it to work. One reason is 
> that inst->sources cannot be trusted

I certainly hope we can trust it.  If it's wrong, we need to fix that.

> so there's no 'easy way' to know how many sources instruction has (?)

There's also opcode_descs[i].nsrc as long as i < 127.  But inst->sources
should be sufficient.

> Plan would be that for any 
> instruction it would check that last one is the only immediate.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150316/1e8294ad/attachment.sig>


More information about the mesa-dev mailing list