[Mesa-dev] [PATCH 2/2] main: Cosmetic updates to GetBufferPointerv.

Fredrik Höglund fredrik at kde.org
Mon Mar 16 23:20:56 PDT 2015


For both patches:

Reviewed-by: Fredrik Höglund <fredrik at kde.org>

On Tuesday 17 March 2015, Laura Ekstrand wrote:
> v3: Review from Fredrik Hoglund
>    -Split cosmetic refactor of GetBufferPointerv out into a separate commit
> ---
>  src/mesa/main/bufferobj.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c
> index 2811604..49d6d32 100644
> --- a/src/mesa/main/bufferobj.c
> +++ b/src/mesa/main/bufferobj.c
> @@ -2051,14 +2051,15 @@ void GLAPIENTRY
>  _mesa_GetBufferPointerv(GLenum target, GLenum pname, GLvoid **params)
>  {
>     GET_CURRENT_CONTEXT(ctx);
> -   struct gl_buffer_object * bufObj;
> +   struct gl_buffer_object *bufObj;
>  
> -   if (pname != GL_BUFFER_MAP_POINTER_ARB) {
> -      _mesa_error(ctx, GL_INVALID_ENUM, "glGetBufferPointervARB(pname)");
> +   if (pname != GL_BUFFER_MAP_POINTER) {
> +      _mesa_error(ctx, GL_INVALID_ENUM, "glGetBufferPointerv(pname != "
> +                  "GL_BUFFER_MAP_POINTER)");
>        return;
>     }
>  
> -   bufObj = get_buffer(ctx, "glGetBufferPointervARB", target,
> +   bufObj = get_buffer(ctx, "glGetBufferPointerv", target,
>                         GL_INVALID_OPERATION);
>     if (!bufObj)
>        return;
> 



More information about the mesa-dev mailing list