[Mesa-dev] [PATCH ] i965/aa: fixing anti-aliasing bug for thinnest width lines.

[Ilia Mirkin]

Can you provide the output of

git var -l

And the headers of the patch file you're sending (or git show
--format=raw for the commit in question if you're not using patch
files as intermediates)

I suspect that GIT_AUTHOR_IDENT will differ from whatever's in the
"From:" header of the patch being sent.


On Tue, Mar 17, 2015 at 12:36 PM, Predut, Marius
<marius.predut at intel.com> wrote:
> -----Original Message-----
> From: mesa-dev [mailto:mesa-dev-bounces at lists.freedesktop.org] On Behalf Of Ilia Mirkin
> Sent: Wednesday, March 11, 2015 11:09 PM
> To: Predut, Marius
> Cc: mesa-dev at lists.freedesktop.org
> Subject: Re: [Mesa-dev] [PATCH ] i965/aa: fixing anti-aliasing bug for thinnest width lines.
>
> On Wed, Mar 11, 2015 at 5:57 PM,  <marius.predut at intel.com> wrote:
>> From: Marius Predut <marius.predut at intel.com>
>
> Set your email from name correctly in git and then you won't have this line in your git send-email results.
>
> I have this config :
>         email = marius.predut at intel.com
>         name = Marius Predut
>
> but still the first line appear
>
>>
>> On SNB and IVB hw, for 1 pixel line thickness or less, the general
>> anti-aliasing algorithm give up - garbage line is generated.
>> Setting a Line Width of 0.0 specifies the rasterization of the
>> “thinnest” (one-pixel-wide), non-antialiased lines.
>> Lines rendered with zero Line Width are rasterized using Grid
>> Intersection Quantization rules as specified by bspec section 6.3.12.1
>> Zero-Width (Cosmetic) Line Rasterization.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82668
>
> This seems like the wrong bug reference...
>
>> Signed-off-by: Marius Predut <marius.predut at intel.com>
>> ---
>>  src/mesa/drivers/dri/i965/gen6_sf_state.c |   12 +++++++++---
>>  1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/i965/gen6_sf_state.c
>> b/src/mesa/drivers/dri/i965/gen6_sf_state.c
>> index f9d8d27..1bed444 100644
>> --- a/src/mesa/drivers/dri/i965/gen6_sf_state.c
>> +++ b/src/mesa/drivers/dri/i965/gen6_sf_state.c
>> @@ -367,9 +367,15 @@ upload_sf_state(struct brw_context *brw)
>>        float line_width =
>>           roundf(CLAMP(ctx->Line.Width, 0.0, ctx->Const.MaxLineWidth));
>>        uint32_t line_width_u3_7 = U_FIXED(line_width, 7);
>> -      /* TODO: line width of 0 is not allowed when MSAA enabled */
>> -      if (line_width_u3_7 == 0)
>> -         line_width_u3_7 = 1;
>> +
>> +      if (!(multisampled_fbo && ctx->Multisample.Enabled)) {
>> +        if (ctx->Line.SmoothFlag && ctx->Line.Width <=1)
>> +              line_width_u3_7 = 0;
>> +      } else {
>> +            if (line_width_u3_7 == 0)
>> +                line_width_u3_7 = 1;
>> +      }
>> +
>>        dw3 |= line_width_u3_7 << GEN6_SF_LINE_WIDTH_SHIFT;
>>     }
>>     if (ctx->Line.SmoothFlag) {
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev