[Mesa-dev] [PATCH 1/6] scons: Disable MSVC signed/unsigned mismatch warnings.

Jose Fonseca jfonseca at vmware.com
Wed Mar 18 09:34:03 PDT 2015


From: José Fonseca <jfonseca at vmware.com>

By default gcc ignores the issue, and as result code that mixes
signed/unsigned is so widespread through the code base that it ends up
being little more than noise, potentially obscuring more pertinent
warnings.

Maybe one day we enable the corresponding gcc warnings and cleanup, but
until then, this change disables them.

Reviewed-by: Brian Paul <brianp at vmware.com>
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
---
 scons/gallium.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scons/gallium.py b/scons/gallium.py
index b162089..9d53848 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -494,6 +494,7 @@ def generate(env):
             ]
         ccflags += [
             '/W3', # warning level
+            '/wd4018', # signed/unsigned mismatch
             '/wd4244', # conversion from 'type1' to 'type2', possible loss of data
             '/wd4305', # truncation from 'type1' to 'type2'
             '/wd4800', # forcing value to bool 'true' or 'false' (performance warning)
-- 
2.1.0



More information about the mesa-dev mailing list