[Mesa-dev] [Mesa-stable] [PATCH] freedreno/a3xx: use the same layer size for all slices

[Ilia Mirkin]

On Wed, Mar 18, 2015 at 8:52 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 13 March 2015 at 04:56, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>> We only program in one layer size per texture, so that means that all
>> levels must share one size. This makes the piglit test
>>
>> bin/texelFetch fs sampler2DArray
>>
>> have the same breakage as its non-array version instead of being
>> completely off.
>>
>> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
>> Cc: "10.4 10.5" <mesa-stable at lists.freedesktop.org>
>> ---
>>
> Hi Ilia,
>
> Picking up this patch for 10.4 is not possible atm, as it depends on
> commit 5d7c9c9160e(freedreno: cleanup slice alignment/setup) which
> reworks setup_slices() and setup_slices_array(). The latter two
> functions are have been reworked further with commits
> 1e3a732603a(freedreno/a4xx: texture fixes) and
> 0ebd623f605(freedreno/a4xx: mipmaps).

Bleh. Oh well.

>
> Your commit 620e29b7482(freedreno: fix slice pitch calculations) seems
> like an nice fix, independent of the above mentioned changes. So I'll
> go ahead and pick it up, unless instructed otherwise.

Sounds good, that should fix 2d (non-array) case with odd widths (like
65... instead of 64... who does that).

>
> Can you let me know if we want 5d7c9c9160e for 10.4 and if so, can
> please confirm the list of dependencies required. I would like to
> avoid breaking the freedreno driver :-)

Can't bring myself to care enough to even glance at adapting it for
10.4 -- leave it alone. Sorry, didn't realize the function had changed
so much.

  -ilia