[Mesa-dev] [PATCH 00/23] Handle Booleans and things better

[Jason Ekstrand]

On Fri, Mar 20, 2015 at 4:59 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 03/20/2015 04:26 PM, Ian Romanick wrote:
>> On 03/20/2015 03:10 PM, Jason Ekstrand wrote:
>>> On Fri, Mar 20, 2015 at 1:58 PM, Ian Romanick <idr at freedesktop.org> wrote:
>>>> There are a couple commits that hurt a fair number of shaders with NIR.
>>>> It doesn't seem like this should be the case, and it seems like there is
>>>> probably work that can be done in brw_fs_nir.cpp to account for this.
>>>
>>> What commits were those?  In particular, what was needed to avoid
>>> regressions from later commits?
>>
>> IIRC, and most of these were written quite some time ago, 2 through 6,
>> ce3f463, and b616164.
>
> Actually, just 2 through 5, ce3f463, and b616164.

Took a look at those.  I don't think we need to back-port them to NIR.
NIR does things enough differently that I don't think they're
applicable.  However, being the AND-instead-of-SEL thing might be
nifty to back-port.  I wouldn't worry about it at the moment though.