[Mesa-dev] [RFC PATCH 11/12] glsl: update types for unsized array members

Timothy Arceri t_arceri at yahoo.com.au
Sat Mar 21 02:49:21 PDT 2015


Assigns a new array type based on the max access of
unsized array members.
---
 src/glsl/linker.cpp | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index eb25163..97f5023 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -1218,8 +1218,7 @@ public:
                resize_interface_members(type_without_array,
                                         var->get_max_ifc_array_access());
             var->change_interface_type(new_type);
-            var->type =
-               glsl_type::get_array_instance(new_type, var->type->length);
+            var->type = update_interface_members_array(var->type, new_type);
          }
       } else if (const glsl_type *ifc_type = var->get_interface_type()) {
          /* Store a pointer to the variable in the unnamed_interfaces
@@ -1267,6 +1266,21 @@ private:
       }
    }
 
+   static const glsl_type *
+   update_interface_members_array(const glsl_type *type,
+                                  const glsl_type *new_interface_type)
+   {
+      const glsl_type *element_type = type->fields.array;
+      if (element_type->is_array()) {
+         const glsl_type *new_array_type =
+            update_interface_members_array(element_type, new_interface_type);
+         return glsl_type::get_array_instance(new_array_type, type->length);
+      } else {
+         return glsl_type::get_array_instance(new_interface_type,
+                                              type->length);
+      }
+   }
+
    /**
     * Determine whether the given interface type contains unsized arrays (if
     * it doesn't, array_sizing_visitor doesn't need to process it).
-- 
2.1.0



More information about the mesa-dev mailing list