[Mesa-dev] [PATCH 07/11] i965: Add notification register

[Matt Turner]

On Sun, Mar 22, 2015 at 6:49 PM, Jordan Justen
<jordan.l.justen at intel.com> wrote:
> This will be used by the wait instruction when implementing the barrier()
> function.
>
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> Reviewed-by: Chris Forbes <chrisf at ijw.co.nz>
> ---
>  src/mesa/drivers/dri/i965/brw_reg.h | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_reg.h b/src/mesa/drivers/dri/i965/brw_reg.h
> index eaf6620..2022ceb 100644
> --- a/src/mesa/drivers/dri/i965/brw_reg.h
> +++ b/src/mesa/drivers/dri/i965/brw_reg.h
> @@ -661,6 +661,22 @@ brw_ip_reg(void)
>  }
>
>  static inline struct brw_reg
> +brw_notification_reg(void)
> +{
> +   return brw_reg(BRW_ARCHITECTURE_REGISTER_FILE,
> +                  BRW_ARF_NOTIFICATION_COUNT,
> +                  0,

I don't know if we'll want to use more than one notification register,
but there are three. The unused code I deleted in commit ebc75245 used
n1. Not sure if there was any reason.

> +                  0,
> +                  0,
> +                  BRW_REGISTER_TYPE_UD,
> +                  BRW_VERTICAL_STRIDE_0,
> +                  BRW_WIDTH_1,
> +                  BRW_HORIZONTAL_STRIDE_0,
> +                  BRW_SWIZZLE_XYZW,

Should be BRW_SWIZZLE_XXXX.

> +                  WRITEMASK_XYZW);

Should be WRITEMASK_X.

With those fixed,

Reviewed-by: Matt Turner <mattst88 at gmail.com>