[Mesa-dev] [PATCH 17/18] i965/cs: Add max_cs_threads

[Jordan Justen]

On 2015-03-22 21:34:19, Kenneth Graunke wrote:
> On Sunday, March 22, 2015 12:39:25 PM Ben Widawsky wrote:
> > On Sat, Mar 14, 2015 at 09:54:27PM -0700, Jordan Justen wrote:
> [snip]
> > > @@ -225,7 +229,8 @@ static const struct brw_device_info 
> brw_device_info_hsw_gt3 = {
> > >     .max_hs_threads = 504,                           \
> > >     .max_ds_threads = 504,                           \
> > >     .max_gs_threads = 504,                           \
> > > -   .max_wm_threads = 384                            \
> > > +   .max_wm_threads = 384,                           \
> > > +   .max_cs_threads = 56 /* threads/subslice */
> > 
> > I think this is wrong for GT1, if such a thing exists (should be 42).
> 
> HSW GT1 is a thing - several Haswell Chromebooks, for example, are GT1.

Unfortunately, the diff makes this confusing. This is actually the
GEN8_FEATURES macro. And, yeah, I think Ben is right that I should set
BDW GT1 to 42, but this setting in the macro makes it 56.

For HSW GT1, it seems like 70 is the right number, and for HSW GT1.5,
it would be 42. (But, we don't have 1.5 in the file.)

I'll clean this up for v2 and I'll try to get numbers for all
configurations, even if I haven't been able to test them yet.

-Jordan