[Mesa-dev] [PATCH] dri3_glx.c: Pass NULL DRI drawables into driver for None GLX drawables

[Axel Davy]

Le 24/03/2015 06:50, Zhang, Xiong Y a écrit :
>> You seem to miss the case when one is None and not the other.
>> It should return BadDrawable too.
>>
>> This particular case seems not handled by the dri2 code either, and the gallium
>> state tracker seems to handle it in bindContext, but not the intel code for
>> example.
> [Zhang, Xiong Y] For this particular case, are you mean this case:
> (draw == None && read != None) || (draw != None && read == None)
> If it is yes, it's better to add this judgement into MakeContextCurrent() in src/glx/glxcurrent.c, so that both dri2_glx and dri3_glx could use it.
>   
> thanks
>
Yes.

I imagine putting it into MakeContextCurrent is not a solution, since it 
means GLXBadContext will be returned instead of GLXBadDrawable.

Axel Davy