[Mesa-dev] [PATCH 1/6] nir: Add glsl_float_type() wrapper.

[Jordan Justen]

On 2015-03-23 17:37:55, Kenneth Graunke wrote:
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/glsl/nir/nir_types.cpp | 6 ++++++
>  src/glsl/nir/nir_types.h   | 1 +
>  2 files changed, 7 insertions(+)
> 
> Patches also available in the `nir-arb` branch of ~kwg/mesa.

Nice results.

With minor comments on 4-6, series
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

Definitely FWIW on patch 2. :)

> diff --git a/src/glsl/nir/nir_types.cpp b/src/glsl/nir/nir_types.cpp
> index a13c3e1..f0d0b46 100644
> --- a/src/glsl/nir/nir_types.cpp
> +++ b/src/glsl/nir/nir_types.cpp
> @@ -143,6 +143,12 @@ glsl_void_type(void)
>  }
>  
>  const glsl_type *
> +glsl_float_type(void)
> +{
> +   return glsl_type::float_type;
> +}
> +
> +const glsl_type *
>  glsl_vec4_type(void)
>  {
>     return glsl_type::vec4_type;
> diff --git a/src/glsl/nir/nir_types.h b/src/glsl/nir/nir_types.h
> index 494051a..276d4ad 100644
> --- a/src/glsl/nir/nir_types.h
> +++ b/src/glsl/nir/nir_types.h
> @@ -69,6 +69,7 @@ bool glsl_type_is_scalar(const struct glsl_type *type);
>  bool glsl_type_is_matrix(const struct glsl_type *type);
>  
>  const struct glsl_type *glsl_void_type(void);
> +const struct glsl_type *glsl_float_type(void);
>  const struct glsl_type *glsl_vec4_type(void);
>  const struct glsl_type *glsl_array_type(const struct glsl_type *base,
>                                          unsigned elements);
> -- 
> 2.3.3
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev