[Mesa-dev] [PATCH v2] i965/fs: in MAD optimizations, switch last argument to be immediate

Emil Velikov emil.l.velikov at gmail.com
Wed Mar 25 15:04:40 PDT 2015


On 16 March 2015 at 08:19, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Monday, March 16, 2015 10:08:08 AM Tapani Pälli wrote:
>> Commit bb33a31 introduced optimizations that transform cases of MAD
>> in to simpler forms but it did not take in to account that src[0]
>> can not be immediate and did not report progress. Patch switches
>> src[0] and src[1] if src[0] is immediate and adds progress
>> reporting. If both sources are immediates, this is taken care of by
>> the same opt_algebraic pass on later run.
>>
>> v2: Fix for all cases, use temporary fs_reg (Matt, Kenneth)
>>
>> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89569
>> Reviewed-by: Francisco Jerez <currojerez at riseup.net> (v1)
...
> Cc: "10.5" <mesa-stable at lists.freedesktop.org>
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
>
Hi gents,

Considering that the MAD optimisations mentioned never made it in 10.5
I'm planning to drop this patch.

Thanks
Emil


More information about the mesa-dev mailing list