[Mesa-dev] [PATCH] tgsi: fix out-of-bounds access for cube arrays

[Roland Scheidegger]

Am 27.03.2015 um 00:06 schrieb Ilia Mirkin:
> The CUBE_ARRAY case uses r[4]. Make sure that the stack variable is
> there.
> 
> Noticed by Coverity.
> 
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> ---
>  src/gallium/auxiliary/tgsi/tgsi_exec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c
> index 8d08059..d9e4050 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_exec.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_exec.c
> @@ -2344,7 +2344,7 @@ exec_sample(struct tgsi_exec_machine *mach,
>  {
>     const uint resource_unit = inst->Src[1].Register.Index;
>     const uint sampler_unit = inst->Src[2].Register.Index;
> -   union tgsi_exec_channel r[4], c1;
> +   union tgsi_exec_channel r[5], c1;
>     const union tgsi_exec_channel *lod = &ZeroVec;
>     enum tgsi_sampler_control control = tgsi_sampler_lod_none;
>     uint chan;
> 

Reviewed-by: Roland Scheidegger <sroland at vmware.com>