[Mesa-dev] [PATCH 2/2] configure.ac: error out if python/mako is not found when required

[Bernd Kuhls]

Hi,

Emil Velikov <emil.l.velikov at gmail.com> wrote in news:1427132964-21468-2-
git-send-email-emil.l.velikov at gmail.com:

> In case of using a distribution tarball (or a dirty git tree) one can
> have the generated sources locally. Make configure.ac error out
> otherwise, to alert that about the unmet requirement(s) of python/mako.

[...]

> +    if test "x$acv_mako_found" = xno; then
> +        if test ! -f "$srcdir/src/glsl/nir/nir_builder_opcodes.h" -o \

I can not find any reference to this file in the mesa3d 10.5.2 tarball. Is 
it save to assume that the check for this file can be removed from the 
patch when applied to 10.5 branch?

When python is missing on the build machine there is still an error using 
these configure options:

--disable-glx --disable-xa --disable-static --enable-shared-glapi --with-
gallium-drivers=nouveau,r600,svga,swrast --without-dri-drivers --disable-
dri3 --enable-opengl --enable-gbm --enable-egl --with-egl-platforms=drm --
enable-gles1 --enable-gles2

make[7]: Entering directory `/home/br/br3/output/build/mesa3d-
10.5.2/src/mesa/drivers/dri/common/xmlpool'
Updating (ca) ca/LC_MESSAGES/options.mo from ca.po.
Updating (de) de/LC_MESSAGES/options.mo from de.po.
Updating (es) es/LC_MESSAGES/options.mo from es.po.
Updating (nl) nl/LC_MESSAGES/options.mo from nl.po.
Updating (fr) fr/LC_MESSAGES/options.mo from fr.po.
Updating (sv) sv/LC_MESSAGES/options.mo from sv.po.
  GEN      options.h
/bin/bash: ./gen_xmlpool.py: Permission denied
make[7]: *** [options.h] Error 126

The reason is src/mesa/drivers/dri/common/xmlpool/Makefile.am, line 66

options.h: t_options.h $(MOS)

Files mentioned in $(MOS) are newer after their creation during the build 
than the pre-supplied options.h.

This hack fixes the build error here:

-options.h: t_options.h $(MOS)
+options.h: t_options.h

Regards, Bernd