[Mesa-dev] [PATCH 3/3] llvmpipe: enable ARB_texture_gather

[Jose Fonseca]

On 30/03/15 01:12, sroland at vmware.com wrote:
> From: Roland Scheidegger <sroland at vmware.com>
>
> Just announce support for 4 components.
> While here also increase the max/min texel offsets (the limit is completely
> artificial, was chosen because that's what other hardware did, however there's
> other drivers using larger limits).
> Over a thousand little piglits skip->pass.
> ---
>   src/gallium/drivers/llvmpipe/lp_screen.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c
> index 4b45725..f4ba596 100644
> --- a/src/gallium/drivers/llvmpipe/lp_screen.c
> +++ b/src/gallium/drivers/llvmpipe/lp_screen.c
> @@ -180,10 +180,10 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>      /* this is a lie could support arbitrary large offsets */
>      case PIPE_CAP_MIN_TEXTURE_GATHER_OFFSET:
>      case PIPE_CAP_MIN_TEXEL_OFFSET:
> -      return -8;
> +      return -32;
>      case PIPE_CAP_MAX_TEXTURE_GATHER_OFFSET:
>      case PIPE_CAP_MAX_TEXEL_OFFSET:
> -      return 7;
> +      return 31;
>      case PIPE_CAP_CONDITIONAL_RENDER:
>         return 1;
>      case PIPE_CAP_TEXTURE_BARRIER:
> @@ -249,6 +249,7 @@ llvmpipe_get_param(struct pipe_screen *screen, enum pipe_cap param)
>      case PIPE_CAP_BUFFER_MAP_PERSISTENT_COHERENT:
>         return 1;
>      case PIPE_CAP_MAX_TEXTURE_GATHER_COMPONENTS:
> +      return 4;
>      case PIPE_CAP_TEXTURE_GATHER_SM5:
>      case PIPE_CAP_TEXTURE_QUERY_LOD:
>      case PIPE_CAP_SAMPLE_SHADING:
>

Series looks good AFAICT.

Jose