[Mesa-dev] [PATCH v2 2/2] radeon/vce: implement video usability information support

[Christian König]

On 31.03.2015 17:22, Leo Liu wrote:
> This will help encoding VUI into the bitstream
>
> v2: make backward compatible
>
> Signed-off-by: Leo Liu <leo.liu at amd.com>
> ---
>   src/gallium/drivers/radeon/radeon_vce.c        |  6 ++-
>   src/gallium/drivers/radeon/radeon_vce.h        |  2 +
>   src/gallium/drivers/radeon/radeon_vce_40_2_2.c | 53 ++++++++++++++++++++++++++
>   3 files changed, 60 insertions(+), 1 deletion(-)
...
> @@ -396,6 +447,8 @@ void radeon_vce_40_2_2_init(struct rvce_encoder *enc)
>   	enc->pic_control = pic_control;
>   	enc->motion_estimation = motion_estimation;
>   	enc->rdo = rdo;
> +	if (enc->use_vui)
> +		enc->vui = vui;

We should set the callback independent of whether or not it is used, 
after all that is just a vtbl.

With that fixed this patch and #1 in this series is Reviewed-by: 
Christian König <christian.koenig at amd.com>.

Regards,
Christian.

>   	enc->encode = encode;
>   	enc->destroy = destroy;
>   }