[Mesa-dev] [PATCH 12/13] i965: Add typed surface access opcodes.

Francisco Jerez currojerez at riseup.net
Mon May 4 04:20:57 PDT 2015

"Pohjolainen, Topi" <topi.pohjolainen at intel.com> writes:

> Unfortunately mail server has purged the original patch number 13. I took
> a look instead in your recent image-load-store-nir branch.

You probably meant the image-load-store-scalar branch?

> I studied the fence mechanism a little in bspec, and based on that I
> can't see anything obvious amiss. Small nit below but:
> Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> Sorry for dropping the ball for such a long time.
> +void
> +brw_memory_fence(struct brw_codegen *p,
> +                 struct brw_reg dst)
> +{
> +   const struct brw_device_info *devinfo = p->devinfo;
> +   const bool commit_enable = (devinfo->gen == 7 && !devinfo->is_haswell);
> You can drop the extra ().

Thank you Topi, I've fixed that locally.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150504/17f393e0/attachment.sig>

More information about the mesa-dev mailing list