[Mesa-dev] [PATCH 7/7] i965/sync: Implement DRI2_Fence extension

[Daniel Stone]

Hi,

On 1 May 2015 at 21:02, Chad Versace <chad.versace at intel.com> wrote:
> +static bool
> +brw_fence_has_completed(struct brw_fence *fence)
> +{
> +   if (fence->signalled)
> +      return true;
> +
> +   if (fence->batch_bo && !drm_intel_bo_busy(fence->batch_bo)) {
> +      drm_intel_bo_unreference(fence->batch_bo);
> +      fence->batch_bo = NULL;

Should this branch be setting fence->signalled = true as well, to
match client_wait?

The rest looks good to me, going on what I remember of having looked
at this about 5 years ago, so:
Reviewed-by: Daniel Stone <daniels at collabora.com>

Cheers,
Daniel