[Mesa-dev] [PATCH] clover: add --with-icd-file-dir option

[Ilia Mirkin]

On Mon, May 4, 2015 at 10:04 AM, Tom Stellard <tom at stellard.net> wrote:
> On Sat, May 02, 2015 at 01:31:41PM -0400, Ilia Mirkin wrote:
>> On Sat, May 2, 2015 at 1:19 PM, EdB <edb+mesa at sigluy.net> wrote:
>> > The standard ICD file path is /etc/OpenCL/vendor/.
>> > However it doesn't fit well with custom build.
>> > This option allow ICD vendor file installation path override
>> > ---
>> >  configure.ac                           | 6 ++++++
>> >  src/gallium/targets/opencl/Makefile.am | 2 +-
>> >  2 files changed, 7 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/configure.ac b/configure.ac
>> > index 095e23e..bf08d76 100644
>> > --- a/configure.ac
>> > +++ b/configure.ac
>> > @@ -2005,6 +2005,12 @@ AC_ARG_WITH([d3d-libdir],
>> >      [D3D_DRIVER_INSTALL_DIR="$withval"],
>> >      [D3D_DRIVER_INSTALL_DIR="${libdir}/d3d"])
>> >  AC_SUBST([D3D_DRIVER_INSTALL_DIR])
>> > +AC_ARG_WITH([icd-file-dir],
>> > +    [AS_HELP_STRING([--with-icd-file-dir=DIR],
>> > +        [directory for the OpenCL ICD vendor file @<:@/etc/OpenCL/vendors@:>@])],
>> > +    [ICD_FILE_INSTALL_DIR="$withval"],
>> > +    [ICD_FILE_INSTALL_DIR="/etc/OpenCL/vendors"])
>>
>> What about making this default to ${sysconfdir}/OpenCL/vendors ? That
>> way using --prefix should auto-make it go into the prefix instead of
>> unexpectedly installing things outside of the specified prefix? That
>> way a distro build which specifies --sysconfdir as /etc will get it in
>> the right place, while by default it'll go into /usr/local/etc and a
>> user can override the icd loader's default behaviour with
>> OPENCL_VENDOR_PATH?
>>
>
> I would prefer not to make this the default behavior, because it violates the spec
> and there could potentially be multiple icd implementations, which may or may not have
> the overrides.
>
> I think the best solution would be to rename the option to something like
> --enable-ocl-icd-respect-prefix (suggestions for other names encouraged).
> and have the option enable the behavior that Ilia is describing.
>
> This will give distros and advanced users a way to setup their system
> the way they want.

It's just a very anti-autoconf thing to do to have "make install" fail
by default unless you specify some "hey, i actually want make install
to work" option.

I think it's crazy to expect that, by default, people will want to
write over their system installs, and having things go outside of the
specified --prefix is very surprising (unless you force some other
option). And asking the user to run "make install" as root is even
crazier.

I guess I haven't hit this yet because there's no OpenCL support in
nouveau or freedreno, but I made the same stink about vdpau when Emil
tried to make it install to some system location by default. At least
a few people seemed to agree with me back then...

  -ilia