[Mesa-dev] [PATCH] mesa: fix shininess check for ffvertex_prog v2

Tim Rowley timothy.o.rowley at intel.com
Mon May 4 14:54:27 PDT 2015

Switch to using VERT_BIT_GENERIC macro.  Downloading piglet and
thought about how to test for this, but it doesn't look like I can
make a test pass/fail based on the tgsi generated (which is the most
straightforward way of testing this).

diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/main/ffvertex_prog.c
index 7fdd9ba..70adaf8 100644
--- a/src/mesa/main/ffvertex_prog.c
+++ b/src/mesa/main/ffvertex_prog.c
@@ -135,7 +135,7 @@ static GLboolean check_active_shininess( struct gl_context *ctx,
        (key->light_color_material_mask & (1 << attr)))
       return GL_TRUE;
-   if (key->varying_vp_inputs & VERT_ATTRIB_GENERIC(attr))
+   if (key->varying_vp_inputs & VERT_BIT_GENERIC(attr))
       return GL_TRUE;
    if (ctx->Light.Material.Attrib[attr][0] != 0.0F)

More information about the mesa-dev mailing list