[Mesa-dev] [PATCH 4/8] glsl: add ARB_vertex_attrib_64bit support.

[Dave Airlie]

On 5 May 2015 at 09:40, Ian Romanick <idr at freedesktop.org> wrote:
> On 04/29/2015 06:13 PM, Dave Airlie wrote:
>> From: Dave Airlie <airlied at redhat.com>
>>
>> Just more boilerplate stuff.
>>
>> Signed-off-by: Dave Airlie <airlied at redhat.com>
>> ---
>>  src/glsl/ast_to_hir.cpp         | 3 +++
>>  src/glsl/glcpp/glcpp-parse.y    | 3 +++
>>  src/glsl/glsl_parser_extras.cpp | 1 +
>>  src/glsl/glsl_parser_extras.h   | 2 ++
>>  4 files changed, 9 insertions(+)
>>
>> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
>> index 18b82e3..d1a5eaf 100644
>> --- a/src/glsl/ast_to_hir.cpp
>> +++ b/src/glsl/ast_to_hir.cpp
>> @@ -3537,6 +3537,9 @@ ast_declarator_list::hir(exec_list *instructions,
>>              switch (check_type->base_type) {
>>              case GLSL_TYPE_FLOAT:
>>              break;
>> +            case GLSL_TYPE_DOUBLE:
>> +               if (state->is_version(410, 0) || state->ARB_vertex_attrib_64bit_enable)
>> +                  break;
>
> If you fall through here, it will bail from the state->is_version(120,
> 300) below.  That's not right.
>
Indeed you are correct,

I've fixed it up, its a little ugly though, maybe something to refactor later.

will resend,

Dave.