[Mesa-dev] [PATCH 4/5] nir: Recognize (a < c || b < c) as min(a, b) < c.

Jordan Justen jordan.l.justen at intel.com
Wed May 6 14:48:54 PDT 2015


On 2015-05-06 14:12:53, Matt Turner wrote:
> ... and (a >= c) || (b >= c) as max(a, b) >= c.

Looks like maybe you could use two commits, since the subject line
overfloweth. Of course, you have shader-db results for them merged. :\

Series Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

> Similar to commit 97e6c1b9.
> 
> total instructions in shared programs: 6182276 -> 6182180 (-0.00%)
> instructions in affected programs:     6400 -> 6304 (-1.50%)
> helped:                                68
> HURT:                                  4
> ---
>  src/glsl/nir/nir_opt_algebraic.py | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/glsl/nir/nir_opt_algebraic.py b/src/glsl/nir/nir_opt_algebraic.py
> index 42f4f47..b0a1f24 100644
> --- a/src/glsl/nir/nir_opt_algebraic.py
> +++ b/src/glsl/nir/nir_opt_algebraic.py
> @@ -101,7 +101,9 @@ optimizations = [
>     (('fsat', ('fsat', a)), ('fsat', a)),
>     (('fmin', ('fmax', ('fmin', ('fmax', a, 0.0), 1.0), 0.0), 1.0), ('fmin', ('fmax', a, 0.0), 1.0)),
>     (('ior', ('flt', a, b), ('flt', a, c)), ('flt', a, ('fmax', b, c))),
> +   (('ior', ('flt', a, c), ('flt', b, c)), ('flt', ('fmin', a, b), c)),
>     (('ior', ('fge', a, b), ('fge', a, c)), ('fge', a, ('fmin', b, c))),
> +   (('ior', ('fge', a, c), ('fge', b, c)), ('fge', ('fmax', a, b), c)),
>     (('slt', a, b), ('b2f', ('flt', a, b)), 'options->lower_scmp'),
>     (('sge', a, b), ('b2f', ('fge', a, b)), 'options->lower_scmp'),
>     (('seq', a, b), ('b2f', ('feq', a, b)), 'options->lower_scmp'),
> -- 
> 2.0.5
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list