[Mesa-dev] [PATCH 5/5] nir: Allow feq/fne/ieq/ine to be optimized with inot.

Ian Romanick idr at freedesktop.org
Wed May 6 16:29:28 PDT 2015


On 05/06/2015 02:12 PM, Matt Turner wrote:
> instructions in affected programs:     380 -> 376 (-1.05%)
> helped:                                2
> ---
> Did we just completely forget these in commit 391fb32b, or is there a
> reason to not include them?

I was recently wondering this as well.  There are similar omissions in
late_optimizations.

>  src/glsl/nir/nir_opt_algebraic.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/glsl/nir/nir_opt_algebraic.py b/src/glsl/nir/nir_opt_algebraic.py
> index b0a1f24..400d60e 100644
> --- a/src/glsl/nir/nir_opt_algebraic.py
> +++ b/src/glsl/nir/nir_opt_algebraic.py
> @@ -83,8 +83,12 @@ optimizations = [
>     # Comparison simplifications
>     (('inot', ('flt', a, b)), ('fge', a, b)),
>     (('inot', ('fge', a, b)), ('flt', a, b)),
> +   (('inot', ('feq', a, b)), ('fne', a, b)),
> +   (('inot', ('fne', a, b)), ('feq', a, b)),
>     (('inot', ('ilt', a, b)), ('ige', a, b)),
>     (('inot', ('ige', a, b)), ('ilt', a, b)),
> +   (('inot', ('ieq', a, b)), ('ine', a, b)),
> +   (('inot', ('ine', a, b)), ('ieq', a, b)),
>     (('fge', ('fneg', ('fabs', a)), 0.0), ('feq', a, 0.0)),
>     (('bcsel', ('flt', a, b), a, b), ('fmin', a, b)),
>     (('bcsel', ('flt', a, b), b, a), ('fmax', a, b)),
> 



More information about the mesa-dev mailing list