[Mesa-dev] [PATCH] main: glGetIntegeri_v fails for GL_VERTEX_BINDING_STRIDE

Tapani Pälli tapani.palli at intel.com
Fri May 8 03:36:50 PDT 2015


That is strange, it was introduced in fb370f89d but then has gone missing ..

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>


On 05/07/2015 06:13 PM, Marta Lofstedt wrote:
> The return type for GL_VERTEX_BINDING_STRIDE is missing,
> this cause glGetIntegeri_v to fail.
>
> Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
> ---
>   src/mesa/main/get.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c
> index 6fc0f3f..9fb8fba 100644
> --- a/src/mesa/main/get.c
> +++ b/src/mesa/main/get.c
> @@ -1959,6 +1959,7 @@ find_value_indexed(const char *func, GLenum pname, GLuint index, union value *v)
>         if (index >= ctx->Const.Program[MESA_SHADER_VERTEX].MaxAttribs)
>             goto invalid_value;
>         v->value_int = ctx->Array.VAO->VertexBinding[VERT_ATTRIB_GENERIC(index)].Stride;
> +      return TYPE_INT;
>
>      /* ARB_shader_image_load_store */
>      case GL_IMAGE_BINDING_NAME: {
>


More information about the mesa-dev mailing list