[Mesa-dev] [PATCH 6/9] mesa/es3.1: Allow Multisampled FrameBufferTextures

[Erik Faye-Lund]

On Mon, May 11, 2015 at 5:21 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Mon, May 11, 2015 at 11:07 AM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
>> On Mon, May 11, 2015 at 4:57 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
>>> On Mon, May 11, 2015 at 10:08 AM, Erik Faye-Lund <kusmabite at gmail.com> wrote:
>>>> Shouldn't this be like this instead (and make sure
>>>> ARB_texture_multisample is enabled for ES3.1)?
>>>>
>>>> @@ -2756,8 +2756,9 @@ _mesa_FramebufferTexture2D(GLenum target, GLenum
>>>> attachment,
>>>>           break;
>>>>        case GL_TEXTURE_2D_MULTISAMPLE:
>>>>        case GL_TEXTURE_2D_MULTISAMPLE_ARRAY:
>>>> -         error = _mesa_is_gles(ctx)
>>>> -            || !ctx->Extensions.ARB_texture_multisample;
>>>> +         error = !ctx->Extensions.ARB_texture_multisample;
>>>
>>> error = false when you have a driver that supports texture_ms, but you
>>> have a gles1/2/3 context, whereas you wanted error = true there...
>>
>> I would expect ctx->Extensions.ARB_texture_multisample to be false in
>> any pre-GLES 3.1 context, since ARB_texture_multisample is written
>> against the OpenGL 3.1 specification, and not any Open GL ES flavor.
>>
>> Are you saying that we do not mask these booleans against what the
>> context can support? Are these purely about what the driver can
>> manage?
>
> Correct. They are exclusively set by the driver and never modified again.

OK. Then yeah, my comments were obviously wrong. Thanks for setting me straight!