[Mesa-dev] [PATCH 1/5] nv30: remove unused nv40_fp_bra() and nvfx_fp_memcpy() functions

Ilia Mirkin imirkin at alum.mit.edu
Tue May 12 08:31:16 PDT 2015


On Tue, May 12, 2015 at 11:25 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
>
>
> On 05/12/2015 05:24 PM, Ilia Mirkin wrote:
>>
>> On Tue, May 12, 2015 at 11:19 AM, Samuel Pitoiset
>> <samuel.pitoiset at gmail.com> wrote:
>>>>>
>>>>> -/* warning: this only works forward, and probably only if not inside
>>>>> any
>>>>> IF */
>>>>> -static void
>>>>> -nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target)
>>>>
>>>> Please keep. This is the only docs for this stuff.
>>>
>>> I didn't know that an unused function could be useful for docs. :-)
>>
>> I'm not aware of any other place where the nv30/nv40 isa is documented :(
>
>
> Not big deal, I'm going to split the patch and send a v2.
>

I'd be perfectly happy with you sticking it into a #if 0 /*
documentation only */ thing if you like... just would rather you
didn't remove it.


More information about the mesa-dev mailing list