[Mesa-dev] [PATCH v2 1/5] nv30: remove unused nvfx_fp_memcpy() function and comment nv40_fp_bra()

[Ilia Mirkin]

Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>

On Tue, May 12, 2015 at 11:35 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> The nv40_fp_bra() function in the same file is also unused but this is
> the only place where the nv30/nv40 isa is documented.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c b/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c
> index bbdca81..9889c4e 100644
> --- a/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c
> +++ b/src/gallium/drivers/nouveau/nv30/nvfx_fragprog.c
> @@ -327,6 +327,8 @@ nv40_fp_rep(struct nvfx_fpc *fpc, unsigned count, unsigned target)
>          //util_dynarray_append(&fpc->loop_stack, unsigned, target);
>  }
>
> +#if 0
> +/* documentation only */
>  /* warning: this only works forward, and probably only if not inside any IF */
>  static void
>  nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target)
> @@ -352,6 +354,7 @@ nv40_fp_bra(struct nvfx_fpc *fpc, unsigned target)
>          reloc.location = fpc->inst_offset + 3;
>          util_dynarray_append(&fpc->label_relocs, struct nvfx_relocation, reloc);
>  }
> +#endif
>
>  static void
>  nv40_fp_brk(struct nvfx_fpc *fpc)
> @@ -1201,17 +1204,3 @@ out_err:
>     tgsi_dump(fp->pipe.tokens, 0);
>     goto out;
>  }
> -
> -static inline void
> -nvfx_fp_memcpy(void* dst, const void* src, size_t len)
> -{
> -#ifndef PIPE_ARCH_BIG_ENDIAN
> -   memcpy(dst, src, len);
> -#else
> -   size_t i;
> -   for(i = 0; i < len; i += 4) {
> -      uint32_t v = *(uint32_t*)((char*)src + i);
> -      *(uint32_t*)((char*)dst + i) = (v >> 16) | (v << 16);
> -   }
> -#endif
> -}
> --
> 2.4.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev