[Mesa-dev] [PATCH 03/29] i965: Define consistent interface to disable control flow execution masking.

Matt Turner mattst88 at gmail.com
Tue May 12 10:30:32 PDT 2015


On Tue, May 12, 2015 at 5:18 AM, Francisco Jerez <currojerez at riseup.net> wrote:
> Kenneth Graunke <kenneth at whitecape.org> writes:
>> On Monday, May 11, 2015 05:12:41 PM Matt Turner wrote:
>>> I think set_* would be better.
>>
>> Agreed.  Reading this in action...
>>
>>    exec_all(bld.MOV(...))
>>
>> sounds a bit funny to me - execute this MOV?
>>
>> set_exec_all or set_writemask_all(MOV(...)) reads a bit nicer - set this
>> property on the given MOV instruction...
>
> Sounds good to me.  I've changed this in my image-load-store-nir branch
> [1], do I need to resend?
>
> [1] http://cgit.freedesktop.org/~currojerez/mesa/log/?h=image-load-store-nir

Thanks. No, I don't think that's necessary.


More information about the mesa-dev mailing list