[Mesa-dev] [PATCH] egl/main: fix EGL_KHR_get_all_proc_addresses

[Chad Versace]

On Tue 12 May 2015, Emil Velikov wrote:
> The extension requires that the address of the core functions should be
> available via eglGetProcAddress. Currently the list is guarded by
> _EGL_GET_CORE_ADDRESSES, which was only set for the scons (windows)
> build.
> 
> Unconditionally enable it for all the builds (automake, android and
> haiku) considering that the extension is not platform specific and is
> always enabled.
> 
> Chad,
> I'm struggling to see if this was working at some point. I'm suspecting
> that it was broken since the beginning - commit 7e8ba77c49b (egl: Expose
> EGL_KHR_get_all_proc_addresses and its client extension) although I may
> be missing something.

It never worked :( . When I wrote commit 7e8ba77c49b, I tested that the
extension strings were exposed correctly. But I failed in correctly
testing that eglGetProcAddress actually *worked* for core functions.

I just sent a Piglit patch, with you cc'd, that adds a test. This Mesa
patch does fix the test.

> If the patch is correct should we just drop the guarding macro rather
> than adding the defines into the build ?

I prefer that we drop the macro. There's no benefit to leaving the macro
in the code, and its mere presence causes bugs because it's easy to
forget to turn it on.