[Mesa-dev] Mesa (master): 57 new commits

[Ian Romanick]

On 05/15/2015 05:26 AM, Fredrik Höglund wrote:
> On Friday 15 May 2015, Michel Dänzer wrote:
>> On 14.05.2015 22:52, fredrik at kemper.freedesktop.org (Fredrik HXXglund)
>> wrote:
>>>
>>> URL:
>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b284f08ab399154ad10e2166440b44cbbdcb2c5
>>> Author: Laura Ekstrand <laura at jlekstrand.net>
>>> Date:   Tue Feb 3 14:47:00 2015 -0800
>>>
>>>     main: _mesa_blit_framebuffer updates its arbitrary framebuffers.
>>>     
>>>     Previously, we used _mesa_update_state to update the currently bound
>>>     framebuffers prior to performing a blit.  Now that _mesa_blit_framebuffer
>>>     uses arbitrary framebuffers, _mesa_update_state is not specific enough.
>>>     
>>>     Reviewed-by: Fredrik Höglund <fredrik at kde.org>
>>>     Signed-off-by: Fredrik Höglund <fredrik at kde.org>
>>
>> This commit broke the piglit test
>> spec at ext_framebuffer_multisample@bitmap with the radeonsi driver:
>>
>> Probe color at (224,0)
>>   Left: 0.000000 0.000000 0.000000 1.000000
>>   Right: 1.000000 1.000000 1.000000 1.000000
>>
>> Looks like it's because the bottom right squares of the Xs are missing,
>> see the attached picture.
>>
>> Any ideas?
> 
> I did notice that failure as well, but when I ran the test manually it
> passed for me, leading me to think that it was a spurious failure.
> 
> The output looks exactly the same for me.  But the test works by
> comparing the left and right halves of the framebuffer, so if the
> bottom right squares are missing on both sides, the test should
> pass.  
> 
> The left side is the test image, and the right side is the reference
> image.

I'm also going to say that I'm quite pissed that this series landed
without my objections being addressed.  I've half a mind to revert the
whole lot!

> Fredrik
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev