[Mesa-dev] [PATCH 44/57] mesa: Add ARB_direct_state_access checks in XFB functions

[Ilia Mirkin]

On Fri, May 15, 2015 at 2:29 PM, Ian Romanick <idr at freedesktop.org> wrote:
> On 05/14/2015 12:51 PM, Ilia Mirkin wrote:
>> Don't you have to add the checks either way? And should these have just been
>>
>> if (ctx->API != CORE && (ctx->API != COMPAT || ctx->Version < 20)) {
>>   ...
>> }
>>
>> And removing compat will just reduce these checks to
>>
>> if (ctx->API != CORE)
>>
>> ?
>
> No.  If you decorate the functions properly in the XML, the would never
> even get put in the dispatch table for a non-core context.  That's the
> whole point.

Would you mind elaborating on how to do that? I see es1/es2/desktop
attributes in the DTD, and it appears that desktop + deprecated ==
COMPAT. But nothing to make it core-only.

  -ilia