[Mesa-dev] [PATCH 3/8] [v2] i965: Add viewport extents (gen8) to batch decode

[Kenneth Graunke]

On Friday, May 15, 2015 10:06:19 PM Ben Widawsky wrote:
> 0x00007da0:      0xc1da740e: SF_CLIP VP: guardband xmin = -27.306667
> 0x00007da4:      0x41da740e: SF_CLIP VP: guardband xmax = 27.306667
> 0x00007da4:      0x41da740e: SF_CLIP VP: guardband ymin = -23.405714
> 0x00007da8:      0xc1bb3ee7: SF_CLIP VP: guardband ymax = 23.405714
> 0x00007db0:      0x00000000: SF_CLIP VP: Min extents: 0.00x0.00
> 0x00007db8:      0x00000000: SF_CLIP VP: Max extents: 299.00x349.00
> 
> While here, fix the wrong offsets for the guardband (I didn't check if it used
> to be valid on GEN4).

SF_CLIP viewport only exists on Gen7+ (there used to be separate SF and
CLIP viewports on older hardware).  So, no - it was never valid.

Thanks for fixing!

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>

> 
> v2: Remove leftover GET_BITS which belongs later in the series. (Topi)
> 
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> Reviewed-by: Topi Pohjolainen <topi.pohjolainen at intel.com>
> ---
>  src/mesa/drivers/dri/i965/brw_state_dump.c | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_state_dump.c b/src/mesa/drivers/dri/i965/brw_state_dump.c
> index aa63c15..ca5a622 100644
> --- a/src/mesa/drivers/dri/i965/brw_state_dump.c
> +++ b/src/mesa/drivers/dri/i965/brw_state_dump.c
> @@ -313,10 +313,17 @@ static void dump_sf_clip_viewport_state(struct brw_context *brw,
>     batch_out(brw, name, offset, 3, "m30 = %f\n", vp->viewport.m30);
>     batch_out(brw, name, offset, 4, "m31 = %f\n", vp->viewport.m31);
>     batch_out(brw, name, offset, 5, "m32 = %f\n", vp->viewport.m32);
> -   batch_out(brw, name, offset, 6, "guardband xmin = %f\n", vp->guardband.xmin);
> -   batch_out(brw, name, offset, 7, "guardband xmax = %f\n", vp->guardband.xmax);
> -   batch_out(brw, name, offset, 8, "guardband ymin = %f\n", vp->guardband.ymin);
> -   batch_out(brw, name, offset, 9, "guardband ymax = %f\n", vp->guardband.ymax);
> +   batch_out(brw, name, offset, 8, "guardband xmin = %f\n", vp->guardband.xmin);
> +   batch_out(brw, name, offset, 9, "guardband xmax = %f\n", vp->guardband.xmax);
> +   batch_out(brw, name, offset, 9, "guardband ymin = %f\n", vp->guardband.ymin);
> +   batch_out(brw, name, offset, 10, "guardband ymax = %f\n", vp->guardband.ymax);
> +   if (brw->gen >= 8) {
> +      float *cc_vp = brw->batch.bo->virtual + offset;
> +      batch_out(brw, name, offset, 12, "Min extents: %.2fx%.2f\n",
> +                cc_vp[12], cc_vp[14]);
> +      batch_out(brw, name, offset, 14, "Max extents: %.2fx%.2f\n",
> +                cc_vp[13], cc_vp[15]);
> +   }
>  }
>  
>  
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150518/02838543/attachment.sig>