[Mesa-dev] [PATCH 0/2] sampler array indexing fixes

Tapani Pälli tapani.palli at intel.com
Tue May 19 05:01:47 PDT 2015


Here are 2 changes, first one relaxes sampler array index validation
during AST->HIR time for GLSL ES versions < 300. Second patch makes sure
that during compilation/linking, index expression has been turned in to

This fixes https://bugs.freedesktop.org/show_bug.cgi?id=84225 which
currently happens with three different WebGL cases.

No Piglit regressions observed, following 2 tests explicitly test this:

glsl-es-1.00/linker/glsl-sampler-array-dynamic-index.shader_test (just sent)

Tapani Pälli (2):
  glsl: Allow dynamic sampler array indexing with GLSL ES < 3.00
  glsl: validate sampler array indexing for 'constant-index-expression'

 src/glsl/ast_array_index.cpp | 37 ++++++++++++-----------
 src/glsl/linker.cpp          | 71 ++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 90 insertions(+), 18 deletions(-)


More information about the mesa-dev mailing list