[Mesa-dev] [PATCH 03/27] glapi: remap_helper.py: Fix some low hanging style issues

Dylan Baker baker.dylan.c at gmail.com
Wed May 20 18:03:00 PDT 2015


From: Dylan Baker <dylanx.c.baker at intel.com>

This makes the tools shut up about a bunch of problems, making them more
useful for catching actual problems.

Signed-off-by: Dylan Baker <dylanx.c.baker at intel.com>
---
 src/mapi/glapi/gen/remap_helper.py | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/mapi/glapi/gen/remap_helper.py b/src/mapi/glapi/gen/remap_helper.py
index e1a13d0..d34e1b5 100644
--- a/src/mapi/glapi/gen/remap_helper.py
+++ b/src/mapi/glapi/gen/remap_helper.py
@@ -24,9 +24,12 @@
 # FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 # IN THE SOFTWARE.
 
-import gl_XML
+import sys
+import getopt
+
 import license
-import sys, getopt, string
+import gl_XML
+
 
 def get_function_spec(func):
     sig = ""
@@ -54,6 +57,7 @@ def get_function_spec(func):
 
     return spec
 
+
 class PrintGlRemap(gl_XML.gl_print_base):
     def __init__(self):
         gl_XML.gl_print_base.__init__(self)
@@ -168,12 +172,13 @@ def show_usage():
     print "    -c ver    Version can be 'es1' or 'es2'."
     sys.exit(1)
 
-if __name__ == '__main__':
+
+def main():
     file_name = "gl_API.xml"
 
     try:
         (args, trail) = getopt.getopt(sys.argv[1:], "f:c:")
-    except Exception,e:
+    except Exception:
         show_usage()
 
     es = None
@@ -190,3 +195,7 @@ if __name__ == '__main__':
 
     printer = PrintGlRemap()
     printer.Print( api )
+
+
+if __name__ == '__main__':
+    main()
-- 
2.4.1



More information about the mesa-dev mailing list