[Mesa-dev] [PATCH 2/2] nv50: fix pipeline statistics queries, based on nvc0

[Samuel Pitoiset]

On 05/21/2015 09:34 PM, Ilia Mirkin wrote:
> Do the piglits currently fail? But this does seem right, although the
> distinction between 64-bit and 32-bit queries is a *bit* unclear to me
> (wrt the diff approaches the code takes).

I tested with the HUD and I compared results between NVA8 and NVD9.

Do we have piglit tests for those queries? I'm not really sure.

>
> On Thu, May 21, 2015 at 3:28 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> These queries use 64 bits. Tested on NVA8.
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   src/gallium/drivers/nouveau/nv50/nv50_query.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/drivers/nouveau/nv50/nv50_query.c b/src/gallium/drivers/nouveau/nv50/nv50_query.c
>> index a3c8841..da41209 100644
>> --- a/src/gallium/drivers/nouveau/nv50/nv50_query.c
>> +++ b/src/gallium/drivers/nouveau/nv50/nv50_query.c
>> @@ -114,7 +114,8 @@ nv50_query_create(struct pipe_context *pipe, unsigned type, unsigned index)
>>
>>      q->is64bit = (type == PIPE_QUERY_PRIMITIVES_GENERATED ||
>>                    type == PIPE_QUERY_PRIMITIVES_EMITTED ||
>> -                 type == PIPE_QUERY_SO_STATISTICS);
>> +                 type == PIPE_QUERY_SO_STATISTICS ||
>> +                 type == PIPE_QUERY_PIPELINE_STATISTICS);
>>      q->type = type;
>>
>>      if (q->type == PIPE_QUERY_OCCLUSION_COUNTER) {
>> --
>> 2.4.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev