[Mesa-dev] [v3 PATCH 06/10] i965: Use _mesa_geometry_ functions appropriately

Rogovin, Kevin kevin.rogovin at intel.com
Thu May 21 17:13:11 PDT 2015

> Strange because of the types -- presumably fb_samples is an int because its uses are in a comparison with another int (that probably doesn't need to be an int :)
I am really hesitant to start changing types all over the place; I have a sinking suspicion that changing the types of fb_width, _height and so on to unsigned int might require some careful checking (the minus ones here and there need some checking. If it really must be done then so be it, but the current series preserves more of the old behavior and I want to try to not add even more changes.

So just to ask explicitly: do you want that those values fb_width = _mesa_geometry_width() and related buggers to be unsigned int and go through the process of making sure unsigned int is ok? There are some uglies related to a few "minus one" 's that make me twitch.

Lastly, when I posted v2 of this series, no one commented on the use of int's. For the v1, Topi requested to have some values start as floats to avoid later casts (and this was done).


More information about the mesa-dev mailing list