[Mesa-dev] [PATCH 2/2] clover: try userptr for CL_MEM_USE_HOST_PTR

Grigori Goronzy greg at chown.ath.cx
Sat May 23 16:17:15 PDT 2015


On 23.05.2015 15:53, Francisco Jerez wrote:
>> diff --git a/src/gallium/state_trackers/clover/core/resource.cpp b/src/gallium/state_trackers/clover/core/resource.cpp
>> index 8ed4c42..8e51b3c 100644
>> --- a/src/gallium/state_trackers/clover/core/resource.cpp
>> +++ b/src/gallium/state_trackers/clover/core/resource.cpp
>> @@ -118,6 +118,8 @@ root_resource::root_resource(clover::device &dev, memory_obj &obj,
>>                               command_queue &q, const std::string &data) :
>>     resource(dev, obj) {
>>     pipe_resource info {};
>> +   bool user_ptr_support = (bool)dev.pipe->get_param(dev.pipe,
> 
> Let's make this variable "const", and remove the cast to bool, it
> shouldn't be necessary.  With that fixed:
> Reviewed-by: Francisco Jerez <currojerez at riseup.net>
>

Thanks for the review. Pushed with minor changes.

Grigori

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150524/98d88006/attachment.sig>


More information about the mesa-dev mailing list