[Mesa-dev] [PATCH 04/11] mesa/st: add support for GL_ARB_cull_distance

[Marek Olšák]

On Sun, May 24, 2015 at 7:58 PM, Tobias Klausmann
<tobias.johannes.klausmann at mni.thm.de> wrote:
> Signed-off-by: Tobias Klausmann <tobias.johannes.klausmann at mni.thm.de>
> ---
>  src/mesa/state_tracker/st_extensions.c |  4 ++++
>  src/mesa/state_tracker/st_program.c    | 34 ++++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+)
>
> diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c
> index 23a4588..63f3334 100644
> --- a/src/mesa/state_tracker/st_extensions.c
> +++ b/src/mesa/state_tracker/st_extensions.c
> @@ -466,6 +466,7 @@ void st_init_extensions(struct pipe_screen *screen,
>        { o(ARB_conditional_render_inverted),  PIPE_CAP_CONDITIONAL_RENDER_INVERTED      },
>        { o(ARB_texture_view),                 PIPE_CAP_SAMPLER_VIEW_TARGET              },
>        { o(ARB_clip_control),                 PIPE_CAP_CLIP_HALFZ                       },
> +      { o(ARB_cull_distance),                PIPE_CAP_CULL_DISTANCE                    },
>        { o(EXT_polygon_offset_clamp),         PIPE_CAP_POLYGON_OFFSET_CLAMP             },
>     };
>
> @@ -678,6 +679,9 @@ void st_init_extensions(struct pipe_screen *screen,
>     if (glsl_feature_level >= 410)
>        extensions->ARB_shader_precision = GL_TRUE;
>
> +   if (glsl_feature_level >= 130)
> +      extensions->ARB_cull_distance = GL_TRUE;
> +

This hunk is wrong and seems to be completely unnecessary.

Also, the patch which adds PIPE_CAP_CULL_DISTANCE should be before this patch.

Marek